Skip to content

Extract duplicated string literals into constants in reader (java:S1192) - #754

Merged
dfa1 merged 1 commit into
dfa1:mainfrom
prajwalpoojari04:fix/738-reader-constants
Nov 18, 2026
Merged

dfa1 merged 1 commit into
dfa1:mainfrom
prajwalpoojari04:fix/738-reader-constants

Conversation

@prajwalpoojari04

Copy link
Copy Markdown
Contributor

Extract the duplicated "chunk" and "filter" parameter-name literals in the reader module's Compute class into private constants (java:S1192).

The constant values are unchanged, so runtime behavior is unchanged. This PR covers the reader module only, as the issue asks for one PR per module.

Refs #738

Tests

  • .\mvnw.cmd verify -pl reader -am: fails in ZstdBuffersEncodingDecoderTest (11 failures, 3 errors) with an error opening the extracted libzstd.dll on my Windows machine. The same failure occurs on a clean checkout of upstream/main, so it is not introduced by this change. I have not identified the underlying cause and could not run those tests locally; I would appreciate CI confirming them.
  • .\mvnw.cmd verify -pl reader -am "-Dtest=*Test,!ZstdBuffersEncodingDecoderTest" "-Dsurefire.failIfNoSpecifiedTests=false": passed (2,516 tests, 0 failures, 0 errors; partial run, Zstd test class excluded).
  • Compute package tests: passed (294 tests).
  • .\mvnw.cmd verify -pl reader -am -DskipTests: passed.

AI assistance: GitHub Copilot SDK in VS Code, Codex , Claude and ChatGPT. I reviewed the implementation and test results.

Refs dfa1#738

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dfa1
dfa1 merged commit b46f274 into dfa1:main Nov 18, 2026
6 checks passed
@prajwalpoojari04
prajwalpoojari04 deleted the fix/738-reader-constants branch November 19, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants